Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Yaml files for Checked C continuous integration jobs #2

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Update Yaml files for Checked C continuous integration jobs #2

merged 7 commits into from
Sep 24, 2024

Conversation

dtarditi
Copy link
Member

@dtarditi dtarditi commented Dec 29, 2023 •
edited
Loading

  • Update to the new location for checkedc-clang: https://github.com/checkedc/checkedc-clang.
  • Change the GitHub CI runners to use latest MacOS and latest Windows.
  • Update the Windows scripts to use the CLANG_REPO and CHECKEDC_REPO variables. They were just being ignored.
  • Fix some typos.

I had to make some changes to the checkedc-clang repos and the checkedc repos.

  • For Windows latest, Python 3.10 no longer has the distutils library. I think distutils was removed the minimum Python distribution that GitHub uses for their CI runners.
  • A few clang compiler tests for CUDA features break on the Windows latest CI. I can't reproduce the failure locally on my machine using a different set up Windows. I disabled the tests. It is not worth looking into them.
  •  - For MacOS latest, some header files now use parameters named ptr. This causes a few Checked C tests that import stdcheckedc.h to break.

Testing:
Successful CI jobs with all of these changes:
MacOS: https://github.com/checkedc/workflows/actions/runs/10877837944
Windows: https://github.com/checkedc/workflows/actions/runs/10866691175
Linux: https://github.com/checkedc/workflows/actions/runs/10867500232

dtarditi and others added 7 commits December 29, 2023 12:57
@dtarditi
Fix typos and remove self-host runner requirement for Windows.
0d64f5e
@dtarditi
Update OS tags.
deb7dda
@dtarditi
Try updating macos tag yet again.
0e97d91
@dtarditi
Update missed macOS tag.
b687c8f
@dtarditi
Try specifying an older version of Python.
f58d800
@dtarditi
Add missing Python library
60e46f5 
Distutils is usually included in Python 3.9 distributions.  For
the GitHub Windows Sesrver 2022, it isn't.  Trying adding setuptools,
which pip substitutes behind the scene for distutils.  Distutils is
deprecated and has been removed from later versions of Python.
When we upgrade our clang ources, we can follow what LLVM has done
for later versions of Python.
@dtarditi
Update Windows scripts to use repo info. Switch to checkedc-clang.
dd17089 
- Switch from using checkedc-llvm-project to checkedc-clang.
- The Windows scripts did not use the clang or Checked C repo locations,
  unlike the Linux scripts. Update them to use them.
@dtarditi dtarditi changed the title Fix typos and remove self-host runner requirement for Windows. Update Yaml files for Checked C continuous integration jobs Sep 16, 2024
@dtarditi dtarditi requested review from Machiry and souragc September 16, 2024 06:42
This was referenced Sep 16, 2024
Merged
Merged
@dtarditi dtarditi merged commit b0957c9 into main Sep 24, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machiry Machiry Awaiting requested review from Machiry

@souragc souragc Awaiting requested review from souragc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dtarditi